Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various QA issues #54

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Fix various QA issues #54

merged 5 commits into from
Jun 28, 2024

Conversation

fourls
Copy link
Collaborator

@fourls fourls commented Jun 28, 2024 •
edited
Loading

This PR:

  • Fixes a number of outstanding Sonar issues across the client, server, and VS Code companion
  • Refactors the quick fix reflow code to lower cognitive complexity (it's much more readable now)
  • Fixes a number of minor memory leaks caused by not passing the doOwnsValues option to TObjectDictionary<T>.Create
  • Sets the source encoding of the delphilint-client Sonar project to UTF-8

@fourls fourls requested a review from Cirras June 28, 2024 02:52
@fourls fourls requested a review from Cirras June 28, 2024 03:33
Cirras
Cirras approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@fourls fourls merged commit 03f5eb7 into master Jun 28, 2024
4 checks passed
@fourls fourls deleted the cleanup branch June 28, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cirras Cirras Cirras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fourls @Cirras